Fix code scanning alert no. 1: Arbitrary file access during archive extraction ("Zip Slip") #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtraction ("Zip Slip")
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/ahmedsza/TechExcel-Accelerate-developer-productivity-with-GitHub-Copilot-and-Dev-Box/security/code-scanning/1
To fix the problem, we need to ensure that the file paths constructed from zip archive entries are validated to prevent writing files to unexpected locations. The steps to fix this are:
Path.Combine(destinationDirectory, entry.FullName)to determine the raw output path.Path.GetFullPath(..)on the raw output path to resolve any directory traversal elements.Path.GetFullPath(destinationDirectory + Path.DirectorySeparatorChar)to determine the fully resolved path of the destination directory.StartsWiththe resolved destination directory, aborting if this is not true.Suggested fixes powered by Copilot Autofix. Review carefully before merging.